Exploration of noble metal-free and highly efficient photoelectrocatalyst for hydrogen production attracts the attention of researchers. The graphitic carbon nitride nanotubes, cadmium sulfide nanorods (NRs) and molybedun disulfide, CdS NRs/MoS2@g-C3N4 nanotubes were synthesized via facile hydrothermal method for hydrogen production studies. The synthesized CdS NRs/MoS2@g-C3N4 nanotubes were studied for electrochemical hydrogen production applications. Structural data revealed that the synthesized composite materials attained crystallinity. Electrochemical investigations demonstrated the highest hydrogen production efficiency of CdS NRs/MoS2@g-C3N4 nanotubes as compared to the bare graphitic carbon nitride nanotubes. This seems that the modification of g-C3N4 NTs with MoS2 increased the photocatalytic efficiency of g-C3N4 NTs. The good efficiency of the CdS NRs/MoS2@g-C3N4 NTs is owing to a unique tubular structure, the presence of active sites, light reflection channel, nanotube composite heterostructure, electron-hole separation, better charge transfer and the synergistic effect. Moreover, it was observed that the tubular structure would be the best photoelectrocatalyst for hydrogen production achieving a geometric current density of 10 mAcm−2 at an overpotential of 0.81 V gives 144 mVdec−1 in 1 M KOH versus the RHE. These results may provide insights into constructing highly efficient photoelectrocatalysts by varying the structural morphology and heterojunction for hydrogen production.