Although testicular germ cell tumours are relatively uncommon they are particularly important as they tend to affect young men and even the advanced metastatic form of the disease has a high cure rate. Treatment is based upon accurate histological diagnosis. Whereas classical tumour patterns are well described and recognized, the relative rarity of some tumour types can lead to diagnostic problems in several important areas. This review highlights two such areas—the distinction of embryonal carcinoma from higher cytological grade variants of classical seminoma, especially when combined, and the recognition of spermatocytic seminoma, including its anaplastic variant. The clinical presentation of young and middle-aged men with metastatic disease with an unknown primary site is a common problem for general histopathologists. This review describes an approach to this with reference to the likelihood of a possible germ cell origin. Late relapses of germ cell tumours can show unusual histological patterns, especially of yolk sac tumour elements. The overall role of immunohistochemistry in germ cell tumour diagnosis is discussed.