Obesity and smoking have been associated with poor prostate cancer (PC) outcomes. We investigated associations between obesity and biochemical recurrence (BCR), metastasis, castrate resistant-PC (CRPC), PC-specific mortality (PCSM), and all-cause mortality (ACM) and examined if smoking modified these associations. We analyzed SEARCH Cohort data from men undergoing RP between 1990 and 2020. Cox regression models were used to estimate hazard ratios (HRs) and 95% confidence intervals (CIs) for associations between body mass index (BMI) as a continuous variable and weight status classifications (normal: 18.5 ≤ 25kg/m2; overweight: 25-29.9kg/m2; obese: ≥ 30kg/m2) and PC outcomes. Among 6,241 men, 1,326 (21%) were normal weight, 2,756 (44%) overweight and 2159 (35%) obese; 1,841 (30%) were never-smokers, 2,768 (44%) former and 1,632 (26%) current-smokers. Among all men, obesity was associated with non-significant increased risk of PCSM, adj-HR = 1.71; 0.98-2.98, P = 0.057, while overweight and obesity were inversely associated with ACM, adj-HR = 0.75; 0.66-0.84, P < 0.001 and adj-HR = 0.86; 0.75-0.99, P = 0.033, respectively. Other associations were null. BCR and ACM were stratified for smoking status given evidence for interactions (P = 0.048 and P = 0.054, respectively). Among current-smokers, overweight was associated with an increase in BCR (adj-HR = 1.30; 1.07-1.60, P = 0.011) and a decrease in ACM (adj-HR = 0.70; 0.58-0.84, P < 0.001). Among never-smokers, BMI (continuous) was associated with an increase in ACM (adj-HR = 1.03; 1.00-1.06, P = 0.033). While our results are consistent with obesity as a risk factor for PCSM, we present evidence of effect modification by smoking for BCR and ACM highlighting the importance of stratifying by smoking status to better understand associations with body weight.