This article uses a co-precipitation method to prepare AgCl/g-C3N4 photocatalysts, and the different loading amounts of AgCl on the g-C3N4 surface photocatalysts have a major effect on the efficiency of photocatalysis. AgCl/g-C3N4 photocatalysts can reduce charge transfer efficiency and enhance photocatalytic performance by loading a significant amount of AgCl onto their surface, which results in a wide interface contact area, excellent charge transfer efficiency, and an increase in numerous surface active sites. In ideal circumstances, 15 % AgCl/g-C3N4 (15 % AgCl/CN) photocatalyst exhibits visible light in triethanolamine aqueous solution (λ > 420) the hydrogen production is as high as 721.34 μmol h−1 g−1 is 15.6 times greater than traditional g-C3N4 photocatalysts. The result show that photocatalysts based on g-C3N4 are capable of producing hydrogen with good efficiency.