Appropriate insulin injection technique can help to enhance positive clinical outcomes in insulin-treated patients. This cross-sectional survey was undertaken to assess the present state of injection technique practices of patients administering insulin and the incidence of local complications associated with insulin injection. This cross-sectional study was conducted at 11 tertiary hospitals in Xi'an City. A total of 1370 patients with diabetes were enroled in the survey. Each patient was asked questions on the Injection Technique questionnaire, demonstrated insulin injection on an injection training pad and had their injection sites inspected by a nurse. About 98% of participants were type 2 diabetic patients. The 5 mm length needles were used by 640 (46.71%) patients. Around 1286 participants reused pen needles. Only one-third of patients rotate the injection sites. Around 901 patients had ecchymosis at injection sites, 43 participants suffered rash and or pruritus and 661 patients had lipohypertrophy. About 2.99% of patients reported having infection at the injection sites. Most patients (72.55%) occasionally felt pain when injecting insulin. The results of the multivariable logistict analysis showed that gender (male), needle length, priming the pen before injections and correct site rotation were negatively associated with the incidence of injection site ecchymosis. Lower incidence of lipohypertrophy was associated with needle length 4 mm, needle length 6 mm, single use of pen needles, priming the pen before injections and correct site rotation. Higher incidence of injection site infection was related to not disinfecting injection sites before each injection. Despite some improvements detected in some aspects of patients' insulin injection practice in recent years, a large gap still exists between insulin injection guidelines and patients' actual injection behaviour. Injection-related complications at injection sites are still considerably common among our study population. Patients' education regarding insulin injection technique should be conducted repeatedly and regularly to make sure patients' compliance to injection guidelines.