A research study was carried out to determine the electrical conductivity (EC), residual sodium carbonate (RSC), sodium adsorption ratio (SAR), p H and metals in metal-polluted irrigation water from a nullah and those in soils over a period of time, and the effect of metals on rice yield and metal concentrations in rice grain and straw. Two sites (I and II) were selected on the bank of Nullah Dek at Thatta Wasiran in Sheikhupura District (Pakistan), with two rice varieties. Super Basmati and Basmati 385, at both sites. Water samples were collected during rice crop growth at 15-day intervals from August 3 to November 1, 2002. The results showed that Nullah Dek water had an EC >1.0 dS m −1 and RSC of 2.78–4.11 mmol c L −1, which was hazardous for crops, but the SAR was within the safe limit. Cu, Mn Cd and Sr were also within safe limits. The soil analysis showed that Site II was free from salinity/sodicity, whereas Site I was saline sodic. Among metals, Zn was sometimes deficient, Cu, Mn and Fe were adequate, and Sr, Ni and Cd were within safe limits in the soil at both the sites. After the rice crop harvest, concentrations of all metals tested were usually slightly increased, being higher in the upper soil layer than the lower. In addition, Basmati 385 produced higher rice grain and straw yield than Super Basmati. Chemical analysis of rice grain indicated the presence of Zn, Cu, Fe, Mn, Pb and Sr, whereas rice straw contained Zn, Cu, Fe, Mn and Sr, with Cd and Ni both being found in minute quantities.